Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table of Contents SEO Updates - Undo Revert #1258

Merged
merged 19 commits into from
Nov 6, 2024
Merged

Table of Contents SEO Updates - Undo Revert #1258

merged 19 commits into from
Nov 6, 2024

Conversation

jsandland
Copy link
Collaborator

Fixes following issues|Adds following features:

  • Resolve bug where how to steps starts at 2 instead of 1
  • Add chevron / toggle chevron up and down to mobile toc
  • Make Table Of Contents sticky on mobile and positioned just below the nav
  • Allow Authors to use short hand titles for the table of contents
  • Allow Authors to control whether numbers are shown for each header corresponding to each table of contents link

Resolves: MWPW-160248
Original PR: #1209

@jsandland
allow shorthand text in table of contents seo block
f48a983
@jsandland
add chevron, attach mobile-toc below nav, margin and padding for mobi…
bd416c0 
…le menu
@jsandland
add border to toc on mobile
a51270b
@jsandland
simplifies position of toc across different pages
df850ba
@jsandland
increase z-index to ensure carousel chevrons stay below the sticky toc
151af42
@jsandland
handle missing class for classList call
3f947e5
@jsandland
ensure smooth transition from sticky to non-sticky on mobile for stic…
fc5dc29 
…ky header and rest of document
@jsandland
use purple color on table of contents title
697b1f9
@jsandland
test toc scroll position stopping at footer
6723136
@jsandland
test footer toc behavior on staging site
a019330
@jsandland
revert toc position changes
7e2b5c7
@jsandland
test if toc can stop at promotions block
d5e8183
@jsandland
stop toc on scroll to top of footer
e282b0d
@jsandland
revert back to promotion test
48bfda4
@jsandland
revert back to original implementation
6b846ed
@jsandland
move toc invoke to loadDelayed()
d1b73b5
@jsandland
prevent toggle of active toc-entry from normal to bold
ae84558
@jsandland
test anchoring toc on element on lower range of y-axis
d52047d
@jsandland
test behavior with footer in staging env
8ea6092
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Nov 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@jsandland jsandland changed the title Jp long form shorthand toc seo Table of Contents SEO Updates - Undo Revert Nov 6, 2024
@JingleH
Copy link
Collaborator

JingleH commented Nov 6, 2024

since this is undoing a revert for a PR already verified, I'm gonna merge and have it catch today's stage to main train

@JingleH JingleH merged commit f72a78b into stage Nov 6, 2024
8 of 9 checks passed
@jsandland jsandland deleted the jp-long-form-shorthand-toc-seo branch November 7, 2024 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingleH JingleH JingleH approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsandland @JingleH